Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using sass as a dependency #119

Merged
merged 2 commits into from
Sep 9, 2016
Merged

Stop using sass as a dependency #119

merged 2 commits into from
Sep 9, 2016

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 9, 2016

With the deprecation of the font #117 we barely use sass. Our css file is 3 lines with no funny sass stuff.

So I'm removing the dependency on the scss file and using Good old CSS. The compiled file ends up in /build/octicons.css just like before.

We also had autoprefixer in the mix, for any prefixes we might need, but we're using css that doesn't require prefixes so killing that also.

@jonrohan jonrohan added this to the v5.0.0 milestone Sep 9, 2016
@jonrohan jonrohan merged commit 115fb9c into master Sep 9, 2016
@jonrohan jonrohan deleted the remove_sass branch September 9, 2016 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant